Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validateLock being called more than once #93

Merged
merged 1 commit into from Apr 11, 2014
Merged

Fix validateLock being called more than once #93

merged 1 commit into from Apr 11, 2014

Conversation

bancek
Copy link
Contributor

@bancek bancek commented Jan 16, 2014

Node crashes if locked file is locked again.

Error: Can't render headers after they are sent to the client.

How to reproduce:

node examples/fileserver.js
curl localhost:8000/1.txt -X LOCK -H "Content-type: text/xml" -d '<?xml version="1.0"?><A:lockinfo xmlns:A="DAV:"><A:locktype><A:write/></A:locktype><A:lockscope><A:shared/></A:lockscope><A:owner><A:href>CURL</A:href></A:owner></A:lockinfo>'
curl localhost:8000/1.txt -X LOCK -H "Content-type: text/xml" -d '<?xml version="1.0"?><A:lockinfo xmlns:A="DAV:"><A:locktype><A:write/></A:locktype><A:lockscope><A:shared/></A:lockscope><A:owner><A:href>CURL</A:href></A:owner></A:lockinfo>'

@mikedeboer
Copy link
Owner

Thanks for tracking this down!

mikedeboer added a commit that referenced this pull request Apr 11, 2014
@mikedeboer
Merge pull request #93 from bancek/upstream
3686602 
Fix validateLock being called more than once
@mikedeboer mikedeboer merged commit 3686602 into mikedeboer:master Apr 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bancek @mikedeboer